Allow For to accept readonly arrays - #950
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 1cf30c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
joeyTedeschi
commented
Jul 6, 2026
| Show.displayName = "Show"; | ||
|
|
||
| type ForEach<T> = | ||
| | ReadonlyArray<T> |
Contributor
Author
There was a problem hiding this comment.
This means that we'd now accept normal arrays as a valid type as well. The const list + listValue logic already supported, but is there a concern with supporting it explicitly?
joeyTedeschi
marked this pull request as ready for review
July 6, 2026 18:32
JoviDeCroock
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<For>accepted list types toReadonlyArray<T>for direct arrays, signals, readonly signals, and function-returned list sourcessignal<readonly T[]>, and computed readonly signals@preact/signalsand@preact/signals-reactWithout this change, attempting to use a
readonlyarray withForresults in aTS 2322(due to assigningreadonly T[]toT[]).PR was created in collaboration with AI (Codex GPT 5.5), which was used to generate the
.changeset/readonly-for-inputs.mdand unit tests. PR was opened in draft, manually audited, and then opened for wider review